Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReadSchema in Qualification tool and NPE in Profiling tool #825

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix ReadSchema in Qualification tool and NPE in Profiling tool #825

merged 2 commits into from
Mar 1, 2024

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Mar 1, 2024

This fixes #824

In this PR, we fix 2 cases:

  1. Fix NPE in profiling tool which is seen in some cases where nodeNames are empty
  2. Qualification tool: Make sure only supported Scan nodes are captured.

Tested it on custom eventlogs.

@nartal1
Fix ReadSchema bug and NPE in Profiling tool
2bcd3d2 
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@nartal1 nartal1 added bug Something isn't working core_tools Scope the core module (scala) labels Mar 1, 2024
@nartal1 nartal1 self-assigned this Mar 1, 2024
@nartal1
Update comment
307304c 
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@nartal1 nartal1 merged commit 66a49d2 into NVIDIA:dev Mar 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattahrens mattahrens mattahrens approved these changes

@parthosa parthosa Awaiting requested review from parthosa

@cindyyuanjiang cindyyuanjiang Awaiting requested review from cindyyuanjiang

Assignees

@nartal1 nartal1

Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
2 participants
@nartal1 @mattahrens